yihua commented on code in PR #13171:
URL: https://github.com/apache/hudi/pull/13171#discussion_r2054508628


##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -91,10 +125,23 @@ public GenericRecord convertToAvroRecord(IndexedRecord 
record, Schema schema) {
 
   @Override
   public Option<HoodieRecordMerger> getRecordMerger(RecordMergeMode mergeMode, 
String mergeStrategyId, String mergeImplClasses) {
-    if (mergeMode == RecordMergeMode.CUSTOM) {
-      return customMerger;
+    switch (mergeMode) {
+      case EVENT_TIME_ORDERING:
+        return Option.of(new HoodiePreCombineAvroRecordMerger());

Review Comment:
   i.e., `HoodieAvroRecordMerger` with `DefaultHoodieRecordPayload` for 
event-time-based semantics.  Is the intention of this line to get rid of the 
payload class usage for `EVENT_TIME_ORDERING`, i.e., directly merging indexed 
records?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to