nsivabalan commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2043004359
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -666,7 +670,7 @@ private void rollbackInflightInstant(HoodieInstant
inflightInstant,
-> entry.getRollbackInstant().getTimestamp())
.orElseGet(HoodieActiveTimeline::createNewInstantTime);
scheduleRollback(context, commitTime, inflightInstant, false,
config.shouldRollbackUsingMarkers(),
- false);
+ false, false);
Review Comment:
Hey @danny0405 : one thing to clarify is.
scheduleClean() has two diff callers prior to this patch, where one of them
was taking a lock and the other was not taking a lock.
w/ this patch, we are standardizing it to take locks in both callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
