danny0405 commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2067711551
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -129,6 +132,23 @@ protected Option<HoodieRollbackPlan>
requestRollback(String startRollbackTime) {
}
}
+ private boolean canProceedWithRollback(HoodieInstant rollbackInstant) {
+ if
(config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
+ // check for concurrent rollbacks. i.e if the commit being rolledback is
already rolled back, we can bail out.
+ HoodieTableMetaClient reloadedMetaClient =
HoodieTableMetaClient.reload(table.getMetaClient());
+ HoodieTimeline reloadedActiveTimeline =
reloadedMetaClient.reloadActiveTimeline();
Review Comment:
just `getActiveTimeline` should be fine because the `reloadedMetaClient` is
fresh new created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
