danny0405 commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2026113209
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -666,7 +670,7 @@ private void rollbackInflightInstant(HoodieInstant
inflightInstant,
-> entry.getRollbackInstant().getTimestamp())
.orElseGet(HoodieActiveTimeline::createNewInstantTime);
scheduleRollback(context, commitTime, inflightInstant, false,
config.shouldRollbackUsingMarkers(),
- false);
+ false, false);
Review Comment:
Can the `skipLocking` flag be maintained outside of the hoodie table or all
kinds of executors? like this:
```java
if (skipLocking) {
scheduleRollback(...)
} else {
txnManager.startTxn ...
scheduleRollback(...)
txnManager.endTxn ...
}
```
I feel like the table and executor should not care about whether the lock
should be used, that would make the code cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
