nsivabalan commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2025891965
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -129,9 +138,36 @@ protected Option<HoodieRollbackPlan>
requestRollback(String startRollbackTime) {
}
}
+ private boolean canProceedWithRollback(HoodieInstant rollbackInstant) {
+ if
(config.getWriteConcurrencyMode().supportsOptimisticConcurrencyControl()) {
+ // check for concurrent rollbacks. i.e if the commit being rolledback is
already rolled back, we can bail out.
+ HoodieTableMetaClient reloadedMetaClient =
HoodieTableMetaClient.reload(table.getMetaClient());
Review Comment:
we could just reload the active timeline and leverage that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
