danny0405 commented on code in PR #13017:
URL: https://github.com/apache/hudi/pull/13017#discussion_r2016188375
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -86,6 +87,15 @@ public static boolean supportRowDataAppend(Configuration
conf, RowType rowType)
||
WriteOperationType.valueOf(conf.get(FlinkOptions.OPERATION).toUpperCase()) ==
WriteOperationType.DELETE);
}
+ /**
+ * Returns whether current index is partition level simple bucket index
based on given configuration {@code conf}.
+ */
+ public static Boolean isPartitionLevelSimpleBucketIndex(Configuration conf) {
+ HoodieIndex.BucketIndexEngineType engineType =
OptionsResolver.getBucketEngineType(conf);
+ return engineType.equals(HoodieIndex.BucketIndexEngineType.SIMPLE)
Review Comment:
> Perhaps we can split the Partition Bucket Index implementation into
Writer and Reader component
if the reader fix also aims to be included in release 1.1, I'm ok with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
