zhangyue19921010 commented on code in PR #13017:
URL: https://github.com/apache/hudi/pull/13017#discussion_r2015964872
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/HoodieSimpleBucketIndex.java:
##########
@@ -152,14 +153,18 @@ protected Function<HoodieRecord,
Option<HoodieRecordLocation>> getIndexLocationF
private class SimpleBucketIndexLocationFunction implements
Function<HoodieRecord, Option<HoodieRecordLocation>> {
private final Map<Integer, HoodieRecordLocation> bucketIdToFileIdMapping;
+ private final NumBucketsFunction numBucketsFunction;
public SimpleBucketIndexLocationFunction(HoodieTable table, String
partitionPath) {
this.bucketIdToFileIdMapping =
loadBucketIdToFileIdMappingForPartition(table, partitionPath);
+ HoodieWriteConfig writeConfig = table.getConfig();
+ this.numBucketsFunction = new
NumBucketsFunction(writeConfig.getBucketIndexPartitionExpression(),
+ writeConfig.getBucketIndexPartitionRuleType(),
writeConfig.getBucketIndexNumBuckets());
Review Comment:
done
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/partition/PartitionBucketIndexUtils.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.index.bucket.partition;
+
+import org.apache.hudi.common.model.PartitionBucketIndexHashingConfig;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView;
+import org.apache.hudi.common.util.VisibleForTesting;
+import org.apache.hudi.exception.HoodieIOException;
+import org.apache.hudi.hadoop.fs.HadoopFSUtils;
+import org.apache.hudi.storage.StorageConfiguration;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.storage.StoragePathInfo;
+import org.apache.hudi.storage.hadoop.HoodieHadoopStorage;
+
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+public class PartitionBucketIndexUtils {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(PartitionBucketIndexUtils.class);
+
+ public static boolean isPartitionSimpleBucketIndex(Configuration conf,
String basePath) {
+ return isPartitionSimpleBucketIndex(HadoopFSUtils.getStorageConf(conf),
basePath);
+ }
+
+ public static boolean isPartitionSimpleBucketIndex(StorageConfiguration
conf, String basePath) {
+ StoragePath storagePath =
PartitionBucketIndexHashingConfig.getHashingConfigStorageFolder(basePath);
+ try (HoodieHadoopStorage storage = new HoodieHadoopStorage(storagePath,
conf)) {
+ return storage.exists(storagePath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to list
PARTITION_BUCKET_INDEX_HASHING_FOLDER folder ", e);
+ }
+ }
+
+ public static Map<String, Integer>
getAllBucketNumbers(PartitionBucketIndexCalculator calc, List<String>
partitions) {
Review Comment:
done
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/partition/RegexRuleEngine.java:
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.index.bucket.partition;
+
+import org.apache.hudi.exception.HoodieException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * Regex-based rule engine implementation.
+ */
+public class RegexRuleEngine implements RuleEngine {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(PartitionBucketIndexCalculator.class);
+ private static final long serialVersionUID = 1L;
+ private final List<RegexRule> rules = new ArrayList<>();
+
+ /**
+ * Represents a single regex rule with its pattern and bucket number.
+ */
+ private static class RegexRule implements Serializable {
+ private static final long serialVersionUID = 1L;
+ private final Pattern pattern;
+ private final int numBuckets;
+
+ public RegexRule(String regex, int numBuckets) {
+ this.pattern = Pattern.compile(regex);
+ this.numBuckets = numBuckets;
+ }
+
+ public boolean matches(String input) {
+ Matcher matcher = pattern.matcher(input);
+ return matcher.find();
+ }
+
+ @Override
+ public String toString() {
+ return pattern.pattern() + " -> " + numBuckets;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
