yihua commented on code in PR #12991:
URL: https://github.com/apache/hudi/pull/12991#discussion_r2001740210
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReaderSchemaHandler.java:
##########
@@ -199,7 +199,8 @@ private static String[]
getMandatoryFieldsForMerging(HoodieTableConfig cfg, Type
}
}
- if (cfg.getRecordMergeMode() == RecordMergeMode.EVENT_TIME_ORDERING) {
+ if (cfg.getRecordMergeMode() == null
+ || cfg.getRecordMergeMode() == RecordMergeMode.EVENT_TIME_ORDERING) {
Review Comment:
A better way is to return the inferred merge mode, `EVENT_TIME_ORDERING` or
`COMMIT_TIME_ORDERING`, from `cfg.getRecordMergeMode()` for table version 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
