linliu-code opened a new pull request, #12991:
URL: https://github.com/apache/hudi/pull/12991

   ### Change Logs
   
   Previously when the configuration "hoodie.record.merge.mode" is null (by 
default), we will not add precombine field to the required schema since we 
assume it is commit time ordering.
   
   But actually we should treat the case that "hoodie.record.merge.mode" is 
null as an unknown, and then try to add the precombine field to the required 
schema as much as possible. Otherwise, for event_time_ordering, it could cause 
ordering value comparison failure.
   
   ### Impact
   
   Fix a bug.
   
   ### Risk level (write none, low medium or high below)
   
   Medium.
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to