danny0405 commented on code in PR #12209:
URL: https://github.com/apache/hudi/pull/12209#discussion_r1839293863
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metadata/TestHoodieMetadataWriteUtils.java:
##########
@@ -41,7 +41,7 @@ public void testCreateMetadataWriteConfigForCleaner() {
.build();
HoodieWriteConfig metadataWriteConfig1 =
HoodieMetadataWriteUtils.createMetadataWriteConfig(writeConfig1,
HoodieFailedWritesCleaningPolicy.EAGER);
- assertEquals(HoodieFailedWritesCleaningPolicy.EAGER,
metadataWriteConfig1.getFailedWritesCleanPolicy());
+ assertEquals(HoodieFailedWritesCleaningPolicy.LAZY,
metadataWriteConfig1.getFailedWritesCleanPolicy());
Review Comment:
In spark write client, we collect the `lastCompletedTxnAndMetadata` and
`pendingInflightAndRequestedInstants` just for contlict resolution, we can
eliminate that as an optimization under NB-CC, because NB-CC just skip the
conflict resolution and these are useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
