danny0405 commented on code in PR #12209:
URL: https://github.com/apache/hudi/pull/12209#discussion_r1839291617
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3455,9 +3455,12 @@ private void validate() {
writeConcurrencyMode.name()));
}
if (writeConcurrencyMode ==
WriteConcurrencyMode.NON_BLOCKING_CONCURRENCY_CONTROL) {
+ //checkArgument(
+ // writeConfig.getTableType().equals(HoodieTableType.MERGE_ON_READ) &&
writeConfig.isSimpleBucketIndex(),
+ // "Non-blocking concurrency control requires the MOR table with
simple bucket index");
checkArgument(
- writeConfig.getTableType().equals(HoodieTableType.MERGE_ON_READ)
&& writeConfig.isSimpleBucketIndex(),
- "Non-blocking concurrency control requires the MOR table with
simple bucket index");
+ writeConfig.getTableType().equals(HoodieTableType.MERGE_ON_READ),
Review Comment:
Only simple bucket index and MDT support NBCC, because MDT is actually with
simple bucket index too, the loose of the check may cause confusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
