satishkotha commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r481365742
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java
##########
@@ -77,6 +79,13 @@ public SpillableMapBasedFileSystemView(HoodieTableMetaClient
metaClient, HoodieT
}
}
+ @Override
+ protected Map<String, Set<String>> createPartitionToExcludeFileGroups() {
+ // TODO should we create another spillable directory under baseStoreDir?
+ // the exclude file group is expected to be small, so use parent class
in-memory representation
+ return super.createPartitionToExcludeFileGroups();
Review comment:
Please take a look if i did it correctly. (To be honest, dont fully
understand compaction implementation in great detail)
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java
##########
@@ -148,6 +148,9 @@
*/
Stream<HoodieFileGroup> getAllFileGroups(String partitionPath);
+ Stream<String> getAllExcludeFileGroups(String partitionPath);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
