satishkotha commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r481364995
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieCommonTestHarness.java
##########
@@ -104,4 +104,8 @@ protected SyncableFileSystemView
getFileSystemViewWithUnCommittedSlices(HoodieTa
protected HoodieTableType getTableType() {
return HoodieTableType.COPY_ON_WRITE;
}
+
+ protected boolean areTimeTravelTestsEnabled() {
Review comment:
RocksDB and Remote FileSystemViews are not implemented yet. So i
temporarily disabled those tests. Moved this method to view tests instead of
common
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/internal/HoodieDataSourceInternalWriter.java
##########
@@ -102,7 +102,7 @@ public void commit(WriterCommitMessage[] messages) {
.flatMap(m -> m.getWriteStatuses().stream().map(m2 ->
m2.getStat())).collect(Collectors.toList());
try {
- writeClient.commitStats(instantTime, writeStatList, Option.empty());
+ writeClient.commitStats(instantTime, writeStatList, Option.empty(),
HoodieTimeline.COMMIT_ACTION); //TODO get action type from
HoodieWriterCommitMessage
Review comment:
Fixed
##########
File path:
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/FileSliceHandler.java
##########
@@ -89,6 +89,10 @@ public FileSliceHandler(Configuration conf,
FileSystemViewManager viewManager) t
.collect(Collectors.toList());
}
+ public List<String> getExcludeFileGroups(String basePath, String
partitionPath) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
