nsivabalan commented on code in PR #7726:
URL: https://github.com/apache/hudi/pull/7726#discussion_r1084615222
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/keygen/TestAutoRecordKeyGenerator.java:
##########
@@ -112,8 +112,9 @@ protected GenericRecord createRecord(String partitionField,
String stringValue,
protected TypedProperties getKeyGenProperties(String partitionPathField, int
numFieldsInKeyGen) {
TypedProperties properties = new TypedProperties();
properties.put(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME.key(),
partitionPathField);
- properties.put(KeyGeneratorOptions.NUM_FIELDS_IN_KEYLESS_GENERATOR.key(),
numFieldsInKeyGen);
+
properties.put(KeyGeneratorOptions.NUM_FIELDS_IN_AUTO_RECORDKEY_GENERATION.key(),
numFieldsInKeyGen);
properties.put(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key(), "");
Review Comment:
yes, we do need it. we will let users override if they wish to. but do have
default value set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
