nsivabalan commented on code in PR #7726:
URL: https://github.com/apache/hudi/pull/7726#discussion_r1084305752


##########
hudi-common/src/main/java/org/apache/hudi/keygen/BaseKeyGenerator.java:
##########
@@ -81,4 +88,10 @@ public List<String> getPartitionPathFields() {
   public boolean isConsistentLogicalTimestampEnabled() {
     return consistentLogicalTimestampEnabled;
   }
+
+  protected void instantiateAutoRecordKeyGenerator() {
+    if (autoGenerateRecordKeys) {
+      autoRecordKeyGenerator = new AutoRecordKeyGenerator(config, 
getPartitionPathFields());

Review Comment:
   issue is, partitionPath fields are set by each concrete class. so within 
BaseKeyGenerator constructor, partitionPaths are not set yet. even I tried and 
realised it later. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to