danny0405 commented on code in PR #6636:
URL: https://github.com/apache/hudi/pull/6636#discussion_r979342415
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/HoodieBucketIndex.java:
##########
@@ -45,12 +48,14 @@ public abstract class HoodieBucketIndex extends
HoodieIndex<Object, Object> {
private static final Logger LOG =
LogManager.getLogger(HoodieBucketIndex.class);
- protected final int numBuckets;
- protected final List<String> indexKeyFields;
+ protected int numBuckets;
+ protected List<String> indexKeyFields;
public HoodieBucketIndex(HoodieWriteConfig config) {
super(config);
-
+ if (config.getBucketIndexEngineType() ==
BucketIndexEngineType.RANGE_BUCKET) {
+ return;
+ }
Review Comment:
We should not write sub-class specific logic in base classes. So let's not
return early here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
