danny0405 commented on code in PR #6636: URL: https://github.com/apache/hudi/pull/6636#discussion_r979342023
########## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bucket/TestHoodieRangeBucketIndex.java: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.index.bucket; + +import org.apache.avro.Schema; +import org.apache.hudi.common.data.HoodieData; +import org.apache.hudi.common.model.HoodieAvroRecord; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.testutils.RawTripTestPayload; +import org.apache.hudi.config.HoodieIndexConfig; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.data.HoodieJavaRDD; +import org.apache.hudi.exception.HoodieIndexException; +import org.apache.hudi.index.HoodieIndex; +import org.apache.hudi.keygen.constant.KeyGeneratorOptions; +import org.apache.hudi.table.HoodieSparkTable; +import org.apache.hudi.table.HoodieTable; +import org.apache.hudi.testutils.HoodieClientTestHarness; +import org.apache.hudi.testutils.HoodieSparkWriteableTestTable; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; +import org.apache.spark.api.java.JavaRDD; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.Properties; + +import static org.apache.hudi.common.testutils.SchemaTestUtil.getSchemaFromResource; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class TestHoodieRangeBucketIndex extends HoodieClientTestHarness { + + private static final Logger LOG = LogManager.getLogger(TestHoodieRangeBucketIndex.class); + private static final Schema SCHEMA = getSchemaFromResource(TestHoodieRangeBucketIndex.class, "/exampleSchema.avsc", true); + private static final int RANGE_BUCKET_STEP_SIZE = 8; + + @BeforeEach + public void setUp() throws Exception { + initSparkContexts(); + initPath(); + initFileSystem(); + // We have some records to be tagged (two different partitions) + initMetaClient(); + } + + @AfterEach + public void tearDown() throws Exception { + cleanupResources(); + } + + @Test + public void testValidateBucketIndexConfig() { + boolean makeConfigSuccess = false; + try { + makeConfig("_row_key,time"); + makeConfigSuccess = true; + } catch (HoodieIndexException e) { + LOG.error(e.getMessage()); + assertFalse(makeConfigSuccess); + makeConfig("_row_key"); + makeConfigSuccess = true; + } + assertTrue(makeConfigSuccess); + } + + @Test + public void testTagLocation() throws Exception { + long rowKey1 = 1; + long rowKey2 = 9; + long rowKey3 = 20; + String recordStr1 = "{\"_row_key\":\"" + rowKey1 + "\",\"time\":\"2016-01-31T03:16:41.415Z\",\"number\":12}"; + String recordStr2 = "{\"_row_key\":\"" + rowKey2 + "\",\"time\":\"2016-01-31T03:20:41.415Z\",\"number\":100}"; + String recordStr3 = "{\"_row_key\":\"" + rowKey3 + "\",\"time\":\"2016-01-31T03:16:41.415Z\",\"number\":15}"; + String recordStr4 = "{\"_row_key\":\"" + rowKey1 + "\",\"time\":\"2015-01-31T03:16:41.415Z\",\"number\":32}"; + RawTripTestPayload rowChange1 = new RawTripTestPayload(recordStr1); + HoodieRecord record1 = new HoodieAvroRecord( + new HoodieKey(rowChange1.getRowKey(), rowChange1.getPartitionPath()), rowChange1); + RawTripTestPayload rowChange2 = new RawTripTestPayload(recordStr2); + HoodieRecord record2 = new HoodieAvroRecord( + new HoodieKey(rowChange2.getRowKey(), rowChange2.getPartitionPath()), rowChange2); + RawTripTestPayload rowChange3 = new RawTripTestPayload(recordStr3); + HoodieRecord record3 = new HoodieAvroRecord( + new HoodieKey(rowChange3.getRowKey(), rowChange3.getPartitionPath()), rowChange3); + RawTripTestPayload rowChange4 = new RawTripTestPayload(recordStr4); + HoodieRecord record4 = new HoodieAvroRecord( + new HoodieKey(rowChange4.getRowKey(), rowChange4.getPartitionPath()), rowChange4); + JavaRDD<HoodieRecord<HoodieAvroRecord>> recordRDD = jsc.parallelize(Arrays.asList(record1, record2, record3, record4)); + HoodieWriteConfig config = makeConfig("_row_key"); + HoodieTable table = HoodieSparkTable.create(config, context, metaClient); + int bucketRangeStepSize = config.getBucketRangeStepSize(); + HoodieRangeBucketIndex bucketIndex = new HoodieRangeBucketIndex(config); + HoodieData<HoodieRecord<HoodieAvroRecord>> taggedRecordRDD = bucketIndex.tagLocation(HoodieJavaRDD.of(recordRDD), context, table); + // even first insert, we should know the location + assertFalse(taggedRecordRDD.collectAsList().stream().anyMatch(r -> !r.isCurrentLocationKnown())); + + HoodieSparkWriteableTestTable testTable = HoodieSparkWriteableTestTable.of(table, SCHEMA); + testTable.addCommit("001").withInserts("2016/01/31", getRecordFileId(record1), record1); + testTable.addCommit("002").withInserts("2016/01/31", getRecordFileId(record2), record2); + testTable.addCommit("003").withInserts("2016/01/31", getRecordFileId(record3), record3); + taggedRecordRDD = bucketIndex.tagLocation(HoodieJavaRDD.of(recordRDD), context, + HoodieSparkTable.create(config, context, metaClient)); + boolean present = taggedRecordRDD.collectAsList().stream().filter(r -> r.isCurrentLocationKnown()) + .filter(r -> BucketIdentifier.bucketIdFromFileId(r.getCurrentLocation().getFileId()) != getRecordBucketId(r)).findAny().isPresent(); + assertFalse(present); + boolean condition = taggedRecordRDD.collectAsList().stream().filter(r -> r.getPartitionPath().equals("2015/01/31") && r.isCurrentLocationKnown()).count() == 1L; + assertTrue(condition); Review Comment: assert the location cnt directly instead of the booleans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
