YuweiXiao commented on code in PR #4958:
URL: https://github.com/apache/hudi/pull/4958#discussion_r917390901
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2600,6 +2629,18 @@ private void validate() {
ValidationUtils.checkArgument(!writeConfig.getString(HoodieCompactionConfig.FAILED_WRITES_CLEANER_POLICY)
.equals(HoodieFailedWritesCleaningPolicy.EAGER.name()), "To enable
optimistic concurrency control, set hoodie.cleaner.policy.failed.writes=LAZY");
}
+
+ if (writeConfig.getIndexType() == HoodieIndex.IndexType.BUCKET &&
writeConfig.getBucketIndexEngineType() ==
HoodieIndex.BucketIndexEngineType.CONSISTENT_HASHING) {
Review Comment:
The logic here guards user from using other clustering strategy when bucket
index is configured. Since it is about modifying clustering options, how about
I moving it to `HoodieClusteringConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
