yanghua commented on code in PR #5827:
URL: https://github.com/apache/hudi/pull/5827#discussion_r895034754
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -403,7 +403,7 @@ private static Boolean tableExists(Connection conn,
Map<String, String> options)
statement.setQueryTimeout(Integer.parseInt(options.get(JDBCOptions.JDBC_QUERY_TIMEOUT())));
statement.executeQuery();
} catch (SQLException e) {
- return false;
+ e.printStackTrace();
Review Comment:
First of all, re-throw an exception means here we may not process it
correctly (e.g. you can not judge that if the table exists.). And we can let
the outer process it or exits naturally if necessary (in the mode, we can also
see the exception detail).
For printing exception details, a better way is to use the logging
framework, if you want to print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
