yanghua commented on code in PR #5827:
URL: https://github.com/apache/hudi/pull/5827#discussion_r894511237
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -403,7 +403,7 @@ private static Boolean tableExists(Connection conn,
Map<String, String> options)
statement.setQueryTimeout(Integer.parseInt(options.get(JDBCOptions.JDBC_QUERY_TIMEOUT())));
statement.executeQuery();
} catch (SQLException e) {
- return false;
+ e.printStackTrace();
Review Comment:
+1 for printing the original exception information. A better way is to throw
the exception but should not let it return true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
