bvaradar commented on a change in pull request #1388: [HUDI-681]Remove
embeddedTimelineService from HoodieReadClient
URL: https://github.com/apache/incubator-hudi/pull/1388#discussion_r390079655
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
##########
@@ -100,14 +91,6 @@ public HoodieReadClient(JavaSparkContext jsc, String
basePath, SQLContext sqlCon
* @param clientConfig instance of HoodieWriteConfig
*/
public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig
clientConfig) {
- this(jsc, clientConfig, Option.empty());
- }
-
- /**
- * @param clientConfig instance of HoodieWriteConfig
- */
- public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig,
- Option<EmbeddedTimelineService> timelineService) {
Review comment:
@yanghua : I am ok as long as with HUDI-661, we are bringing back
TimelineService support for ReadClient. We need to make sure HUDI-661 is also
addressed quickly before next release (0.6.0). I understand that refactoring
these pieces is sometimes tricky and am ok with your approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
