bvaradar commented on a change in pull request #1388: [HUDI-681]Remove 
embeddedTimelineService from HoodieReadClient
URL: https://github.com/apache/incubator-hudi/pull/1388#discussion_r389797461
 
 

 ##########
 File path: 
hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
 ##########
 @@ -100,14 +91,6 @@ public HoodieReadClient(JavaSparkContext jsc, String 
basePath, SQLContext sqlCon
    * @param clientConfig instance of HoodieWriteConfig
    */
   public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig 
clientConfig) {
-    this(jsc, clientConfig, Option.empty());
-  }
-
-  /**
-   * @param clientConfig instance of HoodieWriteConfig
-   */
-  public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig,
-      Option<EmbeddedTimelineService> timelineService) {
 
 Review comment:
   Thanks @vinothchandar  for pointing me to this change. @yanghua : Just 
catching up on this. Instead of completely removing EmbeddedTimelineService 
from HoodieReadClient, did you try removing SparkConf dependency from  
EmbeddedTimelineService thereby also making it generic. I wanted to make sure 
all APIs of hudi client go through Embedded timeline service so that we can 
guarantee meaningful advantage when using timeline service in future. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to