nsivabalan commented on issue #1004: [HUDI-328] Adding delete api to 
HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-555788563
 
 
   @bvaradar : Have updated with the fix. 
   - As per our discussion, SaveMode.Append is the only mode applicable for 
deletes. 
   - Not performing drop duplicates for deletes
   - Fixed the commitOnAutoCommit in delete path where all keys are non 
existent.
   
   You are good to review the patch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to