nsivabalan commented on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-554684563 @bvaradar @bhasudha : I have added support for delete in data sources too in this pull request. Just an iterative change compared to HoodieWriteClient. Hence have added a latest commit. I have few questions on that end 1. I haven't made any checks for save mode in deletes. Can one of you guys advise me on what all save mode is applicable in delete and whats expected behavior. I thought some may not be applicable to deletes and hence wanted your opinions. FYI: Here are the save mode in write path. - ErrorIfExists : will throw error if dataset exists - Ignore: If dataset already exists, do not make any write and return silently. - Overwrite: if data set exists, delete and overwrite. 2. I haven't done anything for dropping duplicates in delete path. Is it required? I am talking something similar to "hoodie.datasource.write.insert.drop.duplicates" for deletes
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
