nsivabalan commented on a change in pull request #1004: [HUDI-328] Adding
delete api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r347961091
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -1123,9 +1177,13 @@ private void rollbackInflightCommits() {
}
}
- private HoodieTable getTableAndInitCtx(JavaRDD<HoodieRecord<T>> records) {
+ private HoodieTable getTableAndInitCtx(String operationType) {
+ HoodieTableMetaClient metaClient = createMetaClient(true);
+ if (operationType.equalsIgnoreCase(DELETE_STR)) {
Review comment:
I thought about it, but it needs MetaClient. For every other operation we
create the metaClient within getTableAndInitCtx. addSchemaToConfig also needs
metaClient and hence I placed it here. Let me know how you want to go about. we
could create Metaclient upfront, but all operations will have to create it and
send it to getTableAndInitCtx() as an arg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
