nsivabalan commented on a change in pull request #1004: [HUDI-328] Adding
delete api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r347077695
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -1171,9 +1175,13 @@ private void rollbackInflightCommits() {
}
}
- private HoodieTable getTableAndInitCtx() {
+ private HoodieTable getTableAndInitCtx(String operationType) {
+ HoodieTableMetaClient metaClient = createMetaClient(true);
+ if (operationType.equalsIgnoreCase(DELETE_STR)) {
+ addSchemaToConfig(metaClient);
Review comment:
@bvaradar : Do you think we should check if config doesn't have schema set
and then add it need be. Bcoz, if someone instantiates the client, does a bunch
of inserts and updates and then deletes, config will have proper schema set.
The problem arises only when someone instantiates the client and issues
delete(which may not have schema set)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
