jerryshao commented on PR #13700: URL: https://github.com/apache/gravitino/pull/13700#issuecomment-6189413831
Addressed in fab1005f8; all threads replied to and resolved. On the review summary's remaining points: - The mark-removal failure path is covered by the same mapping change: a mark without a deletion no longer makes a job CANCELLED. - Test gaps: added `testCancelConflictRetriesRunOut` (four 409s: the cancel throws, the job isn't marked nor deleted, and a later cancel succeeds) and `testCancelWhoseDeletionFailsAfterTheJobIsGone`. - The `maxBytes` contract on `JobExecutor`: left as is in this PR, and added to the follow-ups of #13554. - Deferred to follow-ups of #13554: the delete preconditions (r4280688355) and `spark.master` (r4281018935). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
