LuciferYang commented on issue #13443: URL: https://github.com/apache/gravitino/issues/13443#issuecomment-5957221863
Closing this one. The description already notes there is no behavioral impact, and that holds up: nothing in the tree uses `TablePO.equals` or `hashCode`. The update path goes through raw SQL with no equality short-circuit, `TablePO` is never a collection element, map key, or dedup target, and the optimistic-version check in `TableMetaService` compares individual getters rather than the whole PO. One thing worth recording for whoever picks this up later: a test that pins the field list should enumerate the declared fields by reflection, the way `testCopyBuilderCarriesEveryField` does. The version in #13444 hardcoded the seven column names, so it would have missed a newly added column, which is the case it was meant to guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
