LuciferYang opened a new issue, #13443:
URL: https://github.com/apache/gravitino/issues/13443

   **What would you like to be improved?**
   
   `TablePO.equals`/`hashCode` cover only the nine `table_info` row columns and 
ignore the seven joined payload fields (`format`, `properties`, `partitions`, 
`sortOrders`, `distribution`, `indexes`, `comment`), so two `TablePO`s that 
differ only in payload compare equal. `equals` and `hashCode` are mutually 
consistent today (both omit the same fields), so this is not a contract 
violation, and row identity is governed by `currentVersion` in practice. No 
in-tree consumer relies on `TablePO.equals`, so there is no behavioral impact. 
Still, the PO should compare all of its fields.
   
   **How should we improve?**
   
   Add the seven payload fields to both `equals` and `hashCode`, in the same 
order, so the PO compares all sixteen fields and the two stay mutually 
consistent.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to