nevzheng commented on PR #13517: URL: https://github.com/apache/gravitino/pull/13517#issuecomment-5916669286
@jerryshao PTAL. All four threads from your Sep 29 re-review are addressed, one commit each: - **Orphan-lane guard** (`:174`): [`9122429cb`](https://github.com/apache/gravitino/pull/13517/commits/9122429cb11bbc303d1e2a6fd6d0f2b7e358c0c1) adds `TestCoreLaneMembership` in `coreUnitTest`. It fails when a Docker-tagged class has no `CoreBackend` tag, and I checked it fails when `@CoreBackend.All` is dropped from `AbstractEntityStorageTest`. The design doc is updated in [`0e66fd6db`](https://github.com/apache/gravitino/pull/13517/commits/0e66fd6db43714d1300047ce3285275081651646). - **H2 Docker exclusion** (`:180`): no ordering dependency. The flag is read inside `doFirst`. Documented in [`67457136f`](https://github.com/apache/gravitino/pull/13517/commits/67457136f87f1f7031d9615a5f2ebe0862d4b7f4). - **`coreTestLaneOf` nested classes** (`CoreTestLaneOf:89`): [`a5ab8df63`](https://github.com/apache/gravitino/pull/13517/commits/a5ab8df634d5a83c83ee8109995bd8a0b4f29f8c) reports member test classes. - **`:core:test` comment** (`:257`): corrected in [`eb4e20a79`](https://github.com/apache/gravitino/pull/13517/commits/eb4e20a7982b395c2bb4903ee86b620923547e6b). - **Description:** stale bullet removed, 8 tests, and after-CI timings filled in. The core critical path is 49m35s → 25m26s. Nevin Sent from my 🤖 (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
