mchades commented on code in PR #13571:
URL: https://github.com/apache/gravitino/pull/13571#discussion_r4133785194


##########
server/src/main/java/org/apache/gravitino/server/web/rest/SemanticModelOperations.java:
##########
@@ -157,4 +203,87 @@ public Response loadSemanticModel(
           OperationType.LOAD, semanticModel, schema, e);
     }
   }
+
+  /**
+   * Exports a Semantic Model as a standalone Apache Ossie YAML or JSON 
document.
+   *
+   * @param metalake The metalake name.
+   * @param catalog The catalog name.
+   * @param schema The schema name.
+   * @param semanticModel The Semantic Model name.
+   * @param format The output format, either {@code yaml} or {@code json}.
+   * @return A response containing the serialized Ossie document.
+   */
+  @GET
+  @Path("{semanticModel}/ossie")
+  @Timed(name = "export-ossie-semantic-model." + 
MetricNames.HTTP_PROCESS_DURATION, absolute = true)
+  @ResponseMetered(name = "export-ossie-semantic-model", absolute = true)

Review Comment:
   Semantic Model authorization is outside the scope of this PR and is being 
implemented in #12867 and #13512. This endpoint serializes the same model 
returned by the existing load endpoint, whose REST authorization is not yet 
available on the current base. The Ossie export endpoint should be covered 
together with the other Semantic Model REST endpoints when #13512 is updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to