jarredhj0214 commented on code in PR #13562:
URL: https://github.com/apache/gravitino/pull/13562#discussion_r4130055357
##########
api/src/main/java/org/apache/gravitino/SupportsCatalogs.java:
##########
@@ -53,6 +53,21 @@ public interface SupportsCatalogs {
*/
Catalog[] listCatalogsInfo() throws NoSuchMetalakeException;
+ /**
+ * List all catalogs with their information in the metalake.
+ *
+ * <p>Implementations may omit catalog properties when {@code
includeProperties} is {@code false}.
+ * The default implementation preserves compatibility by returning the
complete catalog
+ * information.
+ *
+ * @param includeProperties whether to include resolved catalog properties
+ * @return The list of catalog's information.
+ * @throws NoSuchMetalakeException If the metalake does not exist.
+ */
+ default Catalog[] listCatalogsInfo(boolean includeProperties) throws
NoSuchMetalakeException {
Review Comment:
Updated, thanks! `listCatalogsInfo()` now delegates to
`listCatalogsInfo(true)`, and the `includeProperties` overload defaults to
throwing `UnsupportedOperationException`. I also applied the same
default-method pattern to the core `SupportsCatalogs` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
