geyanggang commented on code in PR #13481:
URL: https://github.com/apache/gravitino/pull/13481#discussion_r4092260611
##########
core/src/main/java/org/apache/gravitino/catalog/TableOperationDispatcher.java:
##########
@@ -292,6 +306,11 @@ public Table alterTable(NameIdentifier ident,
TableChange... changes)
nameIdentifierForLock.equals(ident) ? LockType.READ : LockType.WRITE,
() -> {
NameIdentifier catalogIdent = getCatalogIdentifier(ident);
+ // Resolve the physical name inside the alter lock so resolution,
the catalog alter and
+ // the store update act atomically on the same object. No-op for
catalogs that do not
+ // implement the resolution capability. The rename target name
inside the changes is left
+ // as-is (a create-like new name follows the normal folding).
+ NameIdentifier resolvedIdent = resolvePhysicalName(ident);
Review Comment:
Removed — that wording belonged to the in-operation revision, which is
reverted. The new Javadoc describes resolution as best-effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
