geyanggang commented on code in PR #13481:
URL: https://github.com/apache/gravitino/pull/13481#discussion_r4090708529
##########
core/src/test/java/org/apache/gravitino/catalog/TestTableNormalizeDispatcher.java:
##########
@@ -275,6 +278,65 @@ public void testCreateTableListTablesLoadTableRoundTrip()
throws Exception {
Assertions.assertEquals("My Table", loadedIdentCaptor.getValue().name());
}
+ @Test
+ public void testResolvePhysicalNameDrivesDownstreamIdentifier() throws
Exception {
Review Comment:
The resolution tests now live in TestTableOperationDispatcher against the
real dispatcher + entity store (not mocks): the round-trip test drives
load/exists/drop through resolution and asserts the store key and no-orphan; a
second test covers exact-match-wins on an ambiguous pair. The not-found path
(resolver returns the input, drop/exists stay boolean) is part of the contract
exercised there. alter/purge share the same in-lock resolvePhysicalName call
site as drop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
