roryqi commented on code in PR #10498:
URL: https://github.com/apache/gravitino/pull/10498#discussion_r2973109227
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -306,7 +313,17 @@ public Response loadTable(
new IcebergRequestContext(httpServletRequest(), catalogName,
isCredentialVending);
LoadTableResponse loadTableResponse =
tableOperationDispatcher.loadTable(context, tableIdentifier);
- return IcebergRESTUtils.ok(loadTableResponse);
+ String metadataLocation =
loadTableResponse.tableMetadata().metadataFileLocation();
Review Comment:
Could u add some tests for
```
Implementations that support ETags should produce unique tags for
responses that return
different metadata content but represent the same version of table
metadata. For example,
the `snapshots` query parameter may result in different metadata
representations depending
on whether `refs` or `all` is provided, therefore should have
distinct ETags.
```
https://github.com/apache/iceberg/blob/a8e9ad2ae02fee5766f71a0783f402680da8e219/open-api/rest-catalog-open-api.yaml#L2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
