laserninja commented on code in PR #10498:
URL: https://github.com/apache/gravitino/pull/10498#discussion_r2972709301
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -306,7 +313,17 @@ public Response loadTable(
new IcebergRequestContext(httpServletRequest(), catalogName,
isCredentialVending);
LoadTableResponse loadTableResponse =
tableOperationDispatcher.loadTable(context, tableIdentifier);
- return IcebergRESTUtils.ok(loadTableResponse);
+ String metadataLocation =
loadTableResponse.tableMetadata().metadataFileLocation();
Review Comment:
Sounds good, updated. createTable and updateTable responses now also include
an ETag header computed from the metadata file location, consistent with
loadTable. Added tests for both. Extracted a buildResponseWithETag() helper to
avoid duplication across the three endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
