jerryshao commented on code in PR #8151: URL: https://github.com/apache/gravitino/pull/8151#discussion_r2289833951
########## mcp-server/mcp_server/client/plain/plain_rest_client_policy_operation.py: ########## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from mcp_server.client import PolicyOperation +from mcp_server.client.plain.utils import extract_content_from_response + + +class PlainRESTClientPolicyOperation(PolicyOperation): + """ + Implementation of PolicyOperation using a plain REST client. + """ + + def __init__(self, metalake_name: str, rest_client): + self.metalake_name = metalake_name + self.rest_client = rest_client + + async def get_list_of_policies(self) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/policies?details=true" + ) + return extract_content_from_response(response, "policies", []) + + async def load_policy( + self, + policy_name: str, + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/policies/{policy_name}" + ) + return extract_content_from_response(response, "policy", {}) + + async def associate_policy_with_metadata( + self, + metadata_full_name: str, + metadata_type: str, + policies_to_add: list, + policies_to_remove: list, + ) -> str: + response = await self.rest_client.post( + f"/api/metalakes/{self.metalake_name}/objects/{metadata_type}/{metadata_full_name}/policies", + json={ + "policiesToAdd": policies_to_add, + "policiesToRemove": policies_to_remove, + }, + ) + return extract_content_from_response(response, "names", []) + + async def get_policy_for_metadata( + self, metadata_full_name: str, metadata_type: str, policy_name: str + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/objects/{metadata_type}/{metadata_full_name}/policies/{policy_name}", + ) + return extract_content_from_response(response, "policy", {}) + + async def list_policies_for_metadata( + self, metadata_full_name: str, metadata_type: str + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/objects/{metadata_type}/{metadata_full_name}/policies/", + ) + return extract_content_from_response(response, "names", []) Review Comment: We should also list the detailed policies for this API if supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
