jerryshao commented on code in PR #8151:
URL: https://github.com/apache/gravitino/pull/8151#discussion_r2289830854
##########
mcp-server/mcp_server/client/plain/plain_rest_client_operation.py:
##########
@@ -52,47 +57,61 @@
from mcp_server.client.topic_operation import TopicOperation
+# pylint: disable=too-many-instance-attributes
class PlainRESTClientOperation(GravitinoOperation):
def __init__(self, metalake_name: str, uri: str):
- self.metalake_name = metalake_name
- self.rest_client = httpx.AsyncClient(base_url=uri)
+ rest_client = httpx.AsyncClient(base_url=uri)
+ self.catalog_operation = PlainRESTClientCatalogOperation(
+ metalake_name, rest_client
+ )
+ self.table_operation = PlainRESTClientTableOperation(
+ metalake_name, rest_client
+ )
+ self.schema_operation = PlainRESTClientSchemaOperation(
+ metalake_name, rest_client
+ )
+ self.topic_operation = PlainRESTClientTopicOperation(
+ metalake_name, rest_client
+ )
+ self.model_operation = PlainRESTClientModelOperation(
+ metalake_name, rest_client
+ )
+ self.tag_operation = PlainRESTClientTagOperation(
+ metalake_name, rest_client
+ )
+ self.fileset_operation = PlainRESTClientFilesetOperation(
+ metalake_name, rest_client
+ )
+ self.job_operation = PlainRESTClientJobOperation(
+ metalake_name, rest_client
+ )
+ self.policy_operation = PlainRESTClientPolicyOperation(
+ metalake_name, rest_client
+ )
Review Comment:
Can you please add the `_` prefix for all the internal variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
