yuqi1129 commented on code in PR #7794:
URL: https://github.com/apache/gravitino/pull/7794#discussion_r2258810471
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -1057,6 +1044,20 @@ private Map<String, Path>
getAndCheckCatalogStorageLocations(Map<String, String>
}
checkPlaceholderValue(v);
+
+ if (!containsPlaceholder(v)) {
+ Path path = new Path(v);
+ FileSystem fs = getFileSystemWithCache(path, conf);
+ try {
+ if (fs.exists(path) && fs.getFileStatus(path).isFile()) {
+ throw new RuntimeException("Fileset catalog location cannot
be a file: " + v);
Review Comment:
> This check for catalog location seems unnecessary, as the schema will also
perform the check, and the catalog will not create a directory for this
location.
We can make exceptions in advance if the location for a catalog exists and
it's a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
