yuqi1129 commented on code in PR #7794:
URL: https://github.com/apache/gravitino/pull/7794#discussion_r2255809009
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -447,6 +446,11 @@ public Fileset createMultipleLocationFileset(
filesetPathsBuilder.put(entry.getKey(), formalizePath);
FileSystem fs = getFileSystemWithCache(formalizePath, conf);
+
+ if (fs.exists(formalizePath) &&
fs.getFileStatus(formalizePath).isFile()) {
+ throw new RuntimeException("Fileset location cannot be a file: " +
formalizePath);
+ }
Review Comment:
Since we have supported a placeholder, we won't be able to get the detailed
path in the schema/catalog level.
Is it acceptable that we only check the path if it doesn't have a
placeholder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
