bharos commented on code in PR #7727:
URL: https://github.com/apache/gravitino/pull/7727#discussion_r2237180046
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/OAuthConfig.java:
##########
@@ -73,4 +73,40 @@ public interface OAuthConfig {
.stringConf()
.checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
+
+ // OAuth provider configs
+ ConfigEntry<String> PROVIDER =
Review Comment:
@jerqi
Is it better to add the documentation when we have the server
implementation? As adding it now in the doc means those configs won't do
anything and it is confusing ?
But if it's ok, I could add it with this PR itself. Or I can add it after
the next PR.
My plan for the main PRs is:
- Add configs (this PR)
- Add server side logic for JWKS validation (currently server only supports
OAuth based on defaultSignKey, I will add logic to get public key from JWKS_URI)
- Add front-end logic to use MSAL based logic for Web UI (if provider=azure)
- Add documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
