bharos commented on code in PR #7727:
URL: https://github.com/apache/gravitino/pull/7727#discussion_r2223562459
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/OAuthConfig.java:
##########
@@ -73,4 +73,48 @@ public interface OAuthConfig {
.stringConf()
.checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
+
+ // Extensible OAuth provider configs
+ ConfigEntry<String> PROVIDER =
+ new ConfigBuilder(OAUTH_CONFIG_PREFIX + "provider")
+ .doc("The OAuth provider to use (e.g., azure)")
+ .version(ConfigConstants.VERSION_0_3_0)
+ .stringConf()
+ .create();
+
+ // Azure-specific configs
+ ConfigEntry<String> AZURE_CLIENT_ID =
+ new ConfigBuilder(OAUTH_CONFIG_PREFIX + "azure.client-id")
Review Comment:
We need client ID for Web UI login. I agree that for machine users like
spark-sql we don't need this, but here, we expose client-id through /configs
API for front end to use it while creating login
##########
server-common/src/main/java/org/apache/gravitino/server/authentication/OAuthConfig.java:
##########
@@ -73,4 +73,48 @@ public interface OAuthConfig {
.stringConf()
.checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
+
+ // Extensible OAuth provider configs
+ ConfigEntry<String> PROVIDER =
+ new ConfigBuilder(OAUTH_CONFIG_PREFIX + "provider")
+ .doc("The OAuth provider to use (e.g., azure)")
+ .version(ConfigConstants.VERSION_0_3_0)
Review Comment:
Thanks, updated
##########
common/src/main/java/org/apache/gravitino/auth/ProviderType.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.auth;
+
+/** The type of OAuth provider. */
+public enum ProviderType {
Review Comment:
Added a DEFAULT type in enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
