jerryshao commented on code in PR #7531:
URL: https://github.com/apache/gravitino/pull/7531#discussion_r2191977331
##########
api/src/main/java/org/apache/gravitino/policy/PolicyOperations.java:
##########
@@ -67,11 +69,18 @@ public interface PolicyOperations {
* @param comment The comment of the policy.
* @param enabled Whether the policy is enabled or not.
* @param content The content of the policy.
+ * @param jobTemplatesToAssociate The list of job templates to associate
with the policy, can be
+ * empty or null if no job templates associated.
* @return The created policy.
* @throws PolicyAlreadyExistsException If the policy already exists.
*/
Policy createPolicy(
- String name, String type, String comment, boolean enabled,
Policy.Content content)
+ String name,
+ String type,
+ String comment,
+ boolean enabled,
+ Policy.Content content,
+ List<JobTemplate> jobTemplatesToAssociate)
Review Comment:
You cannot do a such assumption, this will introduce lots of issues, not
just for the scenario here, but also for the template rename.
If one policy has a job template A, then A renamed to B, this policy should
have job template B, not empty job templates. But in your assumption, then it
will have no job template associated to policy.
If at that time, when the policy is creating, the template is not existed.
Then the created policy will not associate with the template. Even after the
template is created, it will not be associated again.
Thinking of the tag association, it is the same scenario. Only when the job
template is existed, the association is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
