mchades commented on code in PR #7476:
URL: https://github.com/apache/gravitino/pull/7476#discussion_r2188865789
##########
core/src/main/java/org/apache/gravitino/listener/api/event/ListMetadataObjectsForTagsFailureEvent.java:
##########
Review Comment:
@FANNG1 could you plz help to review this part when you have time? thx!
##########
docs/open-api/openapi.yaml:
##########
@@ -77,6 +77,9 @@ paths:
/metalakes/{metalake}/tags/{tag}/objects:
$ref:
"./tags.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1tags~1%7Btag%7D~1objects"
+ /metalakes/{metalake}/tags/objects:
Review Comment:
I realize that this request path may conflict with getting a tag? We may
need to define a new path.
The following are two solutions that come to my mind:
1. Treat `objects` as a reserved tag name, which may break compatibility.
(If the user already has a tag named `objects`, it cannot be retrieved anymore)
2. using `GET /metalakes/{metalake}/objects?tags=tag1,tag2`
I prefer the solution 2, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
