pjfanning commented on code in PR #7548:
URL: https://github.com/apache/gravitino/pull/7548#discussion_r2181162644
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/utils/DataSourceUtils.java:
##########
@@ -76,6 +78,41 @@ private static Properties getProperties(JdbcConfig
jdbcConfig) {
return properties;
}
+ private static void validateJdbcConfig(JdbcConfig jdbcConfig) {
+ String driver = jdbcConfig.getJdbcDriver();
+ String url = jdbcConfig.getJdbcUrl();
+ Map<String, String> all = jdbcConfig.getAllConfig();
+ String lowerUrl = url == null ? "" : url.toLowerCase();
Review Comment:
The Zeppelin code only URL decodes as part of checking for problematic query
parameters. If the URL is accepted as valid, the raw URL is passed to the JDBC
Driver.
I have seen a few projects use URL decoding as part of this JDBC URL checks
but looking at the related issues and PR descriptions that bring in the URL
decoding, little evidence is brought in that the URL decoding is necessary.
I suspect that the evidence could be in mailing lists and deliberately not
discussed in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
