pjfanning commented on code in PR #7548:
URL: https://github.com/apache/gravitino/pull/7548#discussion_r2179779586
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/utils/DataSourceUtils.java:
##########
@@ -76,6 +78,41 @@ private static Properties getProperties(JdbcConfig
jdbcConfig) {
return properties;
}
+ private static void validateJdbcConfig(JdbcConfig jdbcConfig) {
+ String driver = jdbcConfig.getJdbcDriver();
+ String url = jdbcConfig.getJdbcUrl();
+ Map<String, String> all = jdbcConfig.getAllConfig();
+ String lowerUrl = url == null ? "" : url.toLowerCase();
+
+ if (driver != null && driver.toLowerCase().contains("mysql")) {
Review Comment:
the point is if you hardcode mysql here, you could also check for mariadb -
eg
```
lowerUrl.startsWith("jdbc:mysql") || lowerUrl.startsWith("jdbc:mariadb")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
