jerqi commented on code in PR #6853:
URL: https://github.com/apache/gravitino/pull/6853#discussion_r2033125619
##########
core/src/main/java/org/apache/gravitino/catalog/OperationDispatcher.java:
##########
@@ -243,12 +243,16 @@ protected boolean isEntityExist(NameIdentifier ident,
Entity.EntityType type) {
}
protected <E extends Entity & HasIdentifier> E getEntity(
- NameIdentifier ident, Entity.EntityType type, Class<E> entityClass) {
+ NameIdentifier ident, Entity.EntityType type, Class<E> entityClass,
boolean throwException) {
try {
return store.get(ident, type, entityClass);
} catch (Exception e) {
- LOG.error(FormattedErrorMessages.STORE_OP_FAILURE, "get", ident, e);
- throw new RuntimeException("Fail to check if entity is existed", e);
+ if (throwException) {
+ LOG.error(FormattedErrorMessages.STORE_OP_FAILURE, "get", ident, e);
+ throw new RuntimeException("Fail to check if entity is existed", e);
Review Comment:
Please remove this line. We don't need this line. You can modify the code
`SchemaOperationDispatcher`#257L to archieve this aim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
