jerqi commented on PR #6853:
URL: https://github.com/apache/gravitino/pull/6853#issuecomment-2785151820
> > I mean that you can modify my code. But they should use the same method.
> > ```
> > if (stringId == null && !isEntityExist(ident, SCHEMA)) {
> > return EntityCombinedSchema.of(alteredSchema)
> > .withHiddenProperties(
> > getHiddenPropertyNames(
> > catalogIdent,
> > HasPropertyMetadata::schemaPropertiesMetadata,
> > alteredSchema.properties()));
> > }
> >
> > long schemaId;
> > if (stringId != null) {
> > schemaId = stringId.id();
> > } else {
> > schemaId = getEntity(ident, SCHEMA, SchemaEntity.class).id();
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > You can refactor the getEntity to adapt it.
>
> I see.
Here it's ok that we don't throw exception. But you need to refactor the
code. It's important use the same method to unify the style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
