FANNG1 commented on code in PR #6746:
URL: https://github.com/apache/gravitino/pull/6746#discussion_r2017789476
##########
core/src/main/java/org/apache/gravitino/listener/api/event/AccessControlEventDispatcher.java:
##########
@@ -86,8 +90,12 @@ public boolean removeUser(String metalake, String user)
throws NoSuchMetalakeExc
eventBus.dispatchEvent(new RemoveUserPreEvent(initiator,
NameIdentifier.of(metalake), user));
try {
- // TODO: add Event
- return dispatcher.removeUser(metalake, user);
+ boolean isExists = dispatcher.removeUser(metalake, user);
+ eventBus.dispatchEvent(
+ new RemoveUserEvent(
+ initiator, NameIdentifier.of(metalake), new UserInfo(user),
isExists));
Review Comment:
For `RemoveUserEvent`, only user name is requred, if using `UserInfo` will
introduce extra burden to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
