Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

[via GitHub]

Abyss-lord commented on code in PR #6746:
URL: https://github.com/apache/gravitino/pull/6746#discussion_r2017782165


##########
core/src/main/java/org/apache/gravitino/listener/api/event/AccessControlEventDispatcher.java:
##########
@@ -86,8 +90,12 @@ public boolean removeUser(String metalake, String user) 
throws NoSuchMetalakeExc
 
     eventBus.dispatchEvent(new RemoveUserPreEvent(initiator, 
NameIdentifier.of(metalake), user));
     try {
-      // TODO: add Event
-      return dispatcher.removeUser(metalake, user);
+      boolean isExists = dispatcher.removeUser(metalake, user);
+      eventBus.dispatchEvent(
+          new RemoveUserEvent(
+              initiator, NameIdentifier.of(metalake), new UserInfo(user), 
isExists));

Review Comment:
   @FANNG1 I ask this question in #6714 , The conclusion is to use `UserInfo` 
in user event not user pre-event.
   
![image](https://github.com/user-attachments/assets/628ce1ff-bd19-43d1-9d2b-252df5820594)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org